feat: Enable HTTP inspection even for absolute links#172
Merged
azu merged 4 commits intotextlint-rule:masterfrom Jan 18, 2026
Merged
Conversation
ajfAfg
force-pushed
the
feat/enable-http-inspection-even-for-absolute-links
branch
from
478851f to
6946661
Compare
azu
reviewed
Jan 13, 2026
src/no-dead-link.ts
Outdated
Comment on lines
+202
to
+203
| // Since fetch is successful, parsing always succeeds | ||
| const base = URL.parse(uri)!.origin; |
Member
There was a problem hiding this comment.
can you avoid to use !.
It is not type safe.
Contributor
Author
There was a problem hiding this comment.
Thank you for your feedback!
I fixed it.
azu
reviewed
Jan 13, 2026
test/no-dead-link.ts
Outdated
| }, | ||
| errors: [ | ||
| { | ||
| message: `/200 is dead. (ENOENT: no such file or directory, access '${process.platform === "win32" ? "D:\\" : "/"}200')`, |
Member
There was a problem hiding this comment.
Maybe, you can use path.resolve('/200')?
Contributor
Author
There was a problem hiding this comment.
Thank you for your feedback!
I fixed it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Links starting with
/, such as/path/to, were always verified against files on the file system. Consequently, even if thebaseURIoption was set to an HTTP/HTTPS URI, links could not be verified over HTTP/HTTPS.Approach
I've added an option to always validate links via HTTP/HTTPS. For backward compatibility, it is disabled by default.
Additionally, I have added testing and documentation for the new option.